Template talk:Item info
Lil' error[edit]
should be:
Fix borders[edit]
See Help:Ask_a_wiki_question#External_images. I cannot use normal images to solve this problem since the table will stretch in all directions. -- Karasu (talk) 19:37, 3 June 2009 (UTC)
Remove links[edit]
When using [[File:Something.jpg]] it automatically creates a redirect. Is there a tag that disables this? -- Karasu (talk) 19:37, 3 June 2009 (UTC)
- This small bug still occurs -- Karasu (talk) 18:30, 4 June 2009 (UTC)
- This can't be changed, although it may be possible to add a div over the image to catch the clicks, such as this:
- It may not work in all browsers though, and it's a lot more markup for a simple image. Think it's worth it? // HeavenMonkey 19:09, 4 June 2009 (UTC)
- Just tested, it works in Firefox (3) and Chrome, not in Internet Explorer (8). Wikis don't support images for layout sadly, so unless someone knows a technique to block a link in IE, this is the best it gets :( // HeavenMonkey 19:15, 4 June 2009 (UTC)
- I'd expect the wiki would have [[Image:Item_tr.gif|something to disable link]]. It's a simple extension IMO, and I'd expect it would be standard. Otherwise we'll have to find another way of adding images (most of which are disabled I think) -- Karasu (talk) 09:20, 5 June 2009 (UTC)
- As far as I know there is only one way, and that's the wiki syntax. And that will always add a link to the
itemimage page. Another way would be to have a couple of classes added in the css file. I don't know who has access to that file, but if some classes could be added to it, the css borders can immediately go. They don't display right in older versions of IE. // HeavenMonkey 10:22, 5 June 2009 (UTC)
- As far as I know there is only one way, and that's the wiki syntax. And that will always add a link to the
- I'd expect the wiki would have [[Image:Item_tr.gif|something to disable link]]. It's a simple extension IMO, and I'd expect it would be standard. Otherwise we'll have to find another way of adding images (most of which are disabled I think) -- Karasu (talk) 09:20, 5 June 2009 (UTC)
- Just tested, it works in Firefox (3) and Chrome, not in Internet Explorer (8). Wikis don't support images for layout sadly, so unless someone knows a technique to block a link in IE, this is the best it gets :( // HeavenMonkey 19:15, 4 June 2009 (UTC)
Staves etc[edit]
Staffs (and especially Kerrsh' staff) have extra indented white text. How do i best include this? Also moar text should be added at the bottom.. instead of having a fixed amount i'd rather have a generator. -- Karasu (talk) 21:30, 3 June 2009 (UTC)
- Isn't it possible to simply add spaces ( ) to the front of a line to indent it? Alternatively you could add a "indent-X" argument and pass it to the line X container as padding-left or margin-left. About a variable amount of lines, when I was building a miniature template I really missed string manipulation and looping. Alas neither extensions are added to this wiki, so you can't get past a fixed amount of lines. On the other hand, 10 lines should usually be enough. You could even go to 20 to be sure. I noticed a lot of tables in there though, I think it could be easier to edit using div's alone. I'll look at this template more when I wake up again. Awesome template anyway. // HeavenMonkey 23:34, 3 June 2009 (UTC)
Couple of changes[edit]
I made a couple of changes to the template:
- added the borders using CSS.
- changed the layout to use mainly divs instead of tables.
- When you give a TextX or an AltTextX, the line shows. If you gave no TextX no brackets will be added around AltTextX. If both TextX and AltTextX contain text, brackets will be added around AltTextX.
- added a {{uc: }} around {{{Custom Color|}}} and {{{Item Color|}}} so it is case insensitive.
- removed the special parts specifically for weapons or upgrade components.
The first three don't really impact the use of the template, but this last one means I removed {{{Item Stats}}} {{{Weapon}}} {{{Req}}} and {{{Attribute}}}. Instead, the exact text can be given and special templates can be built on this template for certain item types. For example, a staff template could be built on this, a martial weapon template, a rune template, etc... // HeavenMonkey 12:47, 4 June 2009 (UTC)
- Very nice! This is exactly how I meant it to be and more! I'll have to check out if there exist any exceptions in color or layout. Like you said with the rock candy etc. I'll start using this template frequently now =D -- Karasu (talk) 12:55, 4 June 2009 (UTC)
- For now, it is possible to create a correct representation of Red Rock Candies by adding a
<span color="#FFFFFF"></span><span style="color:white;"></span> around the amount of candies. It's not clean but it should work. // HeavenMonkey 12:59, 4 June 2009 (UTC)
- For now, it is possible to create a correct representation of Red Rock Candies by adding a
Examples[edit]
See Talk:40/40#Just_for_teh_fun. It's almost an exact replica of the real bars! =D -- Karasu (talk) 15:57, 4 June 2009 (UTC)
- The ball is there, let's hope snow will stick to it :P // HeavenMonkey 20:02, 4 June 2009 (UTC)
Replacing item info with templates[edit]
I think many people will like this. For example adding the unique item ( Kerrsh's Staff) templates on its own page. This will also replace any in-game images that we were previously using on 40/40 etc. Please add stuff to this list and discuss below. -- Karasu (talk) 09:25, 5 June 2009 (UTC)
Examples are running on Kerrsh's Staff and each unique caster weapon.
- Pro
- Data is presented more clearly and exactly like in-game
- We could add fields to each line to improve searching or interaction with scripts
- Unlike images, you can copy the text
- Con
- Also.. if we do implement these - I suggest we put the templates on wiki/item name/template and include them as such. Or we could just put it in the page, if it wouldn't clutter it too much. -- Karasu (talk) 10:43, 5 June 2009 (UTC)
- Eww, I think the ones you've done look horrible. Please stop until you have community consensus on this. -- Wyn 10:58, 5 June 2009 (UTC)
- Would you mind elaborating what exactly is horrible about it? // HeavenMonkey 11:07, 5 June 2009 (UTC)
- I don't think they're at all horrible, in fact I like them, just one question: Can they be wikified? Linking the attributes and so on, as that tends to be useful (at least for me). Freedom Bound 11:12, 5 June 2009 (UTC)
- Since a lot of different item types have different rules about what lines they have and what colours they are, I think the
betsbest would be to built templates on top of this template for different item types. So a Staff template, a martial template, a rune template, etc. // HeavenMonkey 11:20, 5 June 2009 (UTC)- I agree on that, Heavenmonkey. And Wyn, what's so terrible? I've only put them on four pages as examples. The question about replacing all the pages and upgrading the template to add new features to each page is just under discussion. Feel free to add your thoughts to Con or Pro. -- Karasu (talk) 11:28, 5 June 2009 (UTC)
- Since a lot of different item types have different rules about what lines they have and what colours they are, I think the
- I don't think they're at all horrible, in fact I like them, just one question: Can they be wikified? Linking the attributes and so on, as that tends to be useful (at least for me). Freedom Bound 11:12, 5 June 2009 (UTC)
- Would you mind elaborating what exactly is horrible about it? // HeavenMonkey 11:07, 5 June 2009 (UTC)
- Eww, I think the ones you've done look horrible. Please stop until you have community consensus on this. -- Wyn 10:58, 5 June 2009 (UTC)
(Reset indent) I agree with Wyn. Not with the eww part but about the need of a community consensus. Plust I think there would have to be a policy change since it states it should be done the other way. Drogo Boffin 11:30, 5 June 2009 (UTC)
- Referring to GWW:UNIQUE, I'm assuming? Should the discussion be moved there? Freedom Bound 11:36, 5 June 2009 (UTC)
- I started a discussion on GWW:FORMAT talk page. If this goes through I doubt we should stick to unique items. -- Karasu (talk) 11:39, 5 June 2009 (UTC)
- I say wait till Wyn comments back and let her tell us where to have the discussion. Drogo Boffin 11:41, 5 June 2009 (UTC)
- They don't fit with the design scheme of GWW in any way, and they stand out horribly on the pages they've been applied to. Of course, I am a single voice, I would seriously suggest waiting until you get a broader selection of input from the RfC link you have placed (which belongs at the top of the list as a new addition, not the bottom btw). You are talking about making a change to thousands of pages on the wiki, and I don't know that enough people would agree, I know I don't. While it may fit with the in game graphics, it doesn't fit with GWW. -- Wyn 11:43, 6 June 2009 (UTC)
- As to where the discussion should take place, this is the discussion you have posted on the RfC, so this is where it should happen, starting multiple topics on the same subject is just going to be confusing. First we see if enough people want to use the template, then we talk about how to fit it into formatting policies and guidelines. <edit> Also, your examples should not be in mainspace, they should be on example pages in your userspace sandboxes maybe? -- Wyn 11:50, 6 June 2009 (UTC)
- They don't fit with the design scheme of GWW in any way, and they stand out horribly on the pages they've been applied to. Of course, I am a single voice, I would seriously suggest waiting until you get a broader selection of input from the RfC link you have placed (which belongs at the top of the list as a new addition, not the bottom btw). You are talking about making a change to thousands of pages on the wiki, and I don't know that enough people would agree, I know I don't. While it may fit with the in game graphics, it doesn't fit with GWW. -- Wyn 11:43, 6 June 2009 (UTC)
- I say wait till Wyn comments back and let her tell us where to have the discussion. Drogo Boffin 11:41, 5 June 2009 (UTC)
- I started a discussion on GWW:FORMAT talk page. If this goes through I doubt we should stick to unique items. -- Karasu (talk) 11:39, 5 June 2009 (UTC)
(Reset indent) Maybe we could make a javascript for monospace. That way certain context can be replaced by this template only for the people who choose so. -- Karasu (talk) 12:00, 6 June 2009 (UTC)
- I'd have to agree with Wyn in that, personally, it doesn't fit the design of GWW. For me, the stark contrast of the dark box on the white background looks tacky, and the border isn't aesthetically appealing to me. Don't get me wrong, I think this would be a wonderful template for something to be used in your personal space, perhaps for someone's "items for sale" section of their userspace, but I don't think it looks good on mainspace articles. If you could find a way to make the contrast not so striking, or even some other completely different design that would fit with the GWW theme, if you will, then I'd say it'd be a great addition. Just my $0.02. --★KOKUOU★ 12:06, 6 June 2009 (UTC)
- I have to agree with Wyn on the esthetics. Further, light text on a black background is hard to read. This may be an artifact due to display settings, but it is a common enough problem that it should be given considerable weight. --Max 2 15:39, 6 June 2009 (UTC)
- I think it could be useful as kinda a tooltip popup, like PvX skill icon mouse-overs. --JonTheMon 16:12, 6 June 2009 (UTC)
- Also, we do not generally do the Pro/Con list thing while making decisions. Straight discussion is always better. -- Wyn 04:07, 7 June 2009 (UTC)
- Its great for userpages but the more I see it on weapon pages the less I like it there. If it is possible a mouseover would be better. Drogo Boffin 14:35, 7 June 2009 (UTC)
- I kinda like it in ways, but in other ways not, one thing I will say though it is looks bad in IE6. --Lemming 23:11, 7 June 2009 (UTC)
- Since this discussion has mostly died without concensus, I have removed the template from the 3 mainspace weapon pages where it had replaced the currently approved formatting. If you wish to provide examples, I suggest copying the pages to your userspace and linking from there. -- Wyn 11:49, 21 June 2009 (UTC)
- I kinda like it in ways, but in other ways not, one thing I will say though it is looks bad in IE6. --Lemming 23:11, 7 June 2009 (UTC)
- Its great for userpages but the more I see it on weapon pages the less I like it there. If it is possible a mouseover would be better. Drogo Boffin 14:35, 7 June 2009 (UTC)
- Also, we do not generally do the Pro/Con list thing while making decisions. Straight discussion is always better. -- Wyn 04:07, 7 June 2009 (UTC)
- I think it could be useful as kinda a tooltip popup, like PvX skill icon mouse-overs. --JonTheMon 16:12, 6 June 2009 (UTC)
- I have to agree with Wyn on the esthetics. Further, light text on a black background is hard to read. This may be an artifact due to display settings, but it is a common enough problem that it should be given considerable weight. --Max 2 15:39, 6 June 2009 (UTC)
Colors[edit]
I figure we'd need Copper and Silver too. Can anyone get the real rgb values? (No access to GW atm) -- Karasu (talk) 11:54, 5 June 2009 (UTC)
- Done ;) // HeavenMonkey 12:08, 5 June 2009 (UTC)
Lists[edit]
As you can see here:
50 Copper Zaishen Coins
|
||
The background elements die when used in lists. Though this is a minor error. Also HeavenMonkey, your code broke the title indent xD -- Karasu (talk) 13:32, 5 June 2009 (UTC)
- Umm that indent error is strange. It appears that a paragraph will not end or so after it's used in an indent. Thus everything after :{{skill info}} will be indented. --The preceding unsigned comment was added by User:Karasu (talk).
- The whole page is weird for me (like the top navigation buttons) even the font or something is changed on the left side panel (Main Page links, etc.) Freedom Bound 13:57, 5 June 2009 (UTC)
- I removed {{clear}] - now it should be better. The indent error is still part of the template though. -- Karasu (talk) 14:07, 5 June 2009 (UTC)
- I don't think it was the template. I had two floating elements with a : in the middle. Not sure what it did, but removing the : fixed the indent. So it wasn't the template :) // HeavenMonkey 11:29, 6 June 2009 (UTC)
- About the list thing, I see every HTML except for the <span> was stripped when the wiki puts it in a list. No way to maintain the layout then. // HeavenMonkey 11:41, 6 June 2009 (UTC)
- Wooh, fixed it by escaping all (relevant = printed)newlines with <!-- --> // HeavenMonkey 22:58, 16 June 2009 (UTC)
- About the list thing, I see every HTML except for the <span> was stripped when the wiki puts it in a list. No way to maintain the layout then. // HeavenMonkey 11:41, 6 June 2009 (UTC)
- I don't think it was the template. I had two floating elements with a : in the middle. Not sure what it did, but removing the : fixed the indent. So it wasn't the template :) // HeavenMonkey 11:29, 6 June 2009 (UTC)
- I removed {{clear}] - now it should be better. The indent error is still part of the template though. -- Karasu (talk) 14:07, 5 June 2009 (UTC)
- The whole page is weird for me (like the top navigation buttons) even the font or something is changed on the left side panel (Main Page links, etc.) Freedom Bound 13:57, 5 June 2009 (UTC)
Links[edit]
Using links in a template will make the text unreadable. What's the best solution for this? -- Karasu (talk) 17:02, 5 June 2009 (UTC)
- I think there's a way to override the color of a link with a span or something. And why is this section indented? --JonTheMon 17:06, 5 June 2009 (UTC)
This template rules...[edit]
I it! --Unendingfear 17:22, 5 June 2009 (UTC)
Parameter standardization[edit]
Since this is a really useful template, and might be used more officially, could we maybe standardise the parameter names? We usually only use lower case, and iirc we try to avoid too long parameters and parameters with spaces in (not sure here). I think it would be nice if all templates used the same pattern :) - anja 17:39, 5 June 2009 (UTC)
- I think HeavenMonkey fixed it so it's case independent. I find uppercase easier though. The paraments aren't that "long" imo too. Do you have any suggestion on what to change to make it more standard? -- Karasu (talk) 17:43, 5 June 2009 (UTC)
- If both works, that would be great, it doesn't seem like it though:
Handaxe
|
||
- I was mainly thinking of item name and item color, why not just name and color, of course it is about an item :) - anja 17:49, 5 June 2009 (UTC)
- I'll add that - it's a simple fix. -- Karasu (talk) 17:51, 5 June 2009 (UTC)
- I changed all the {{uc:}} to {{lc:}} since you added some lowercase words in the switch. Still case insensative, only now the lowercase words in the switch will match. But if we are going to kick all capitals from the template, the sooner the better. When the template is used widely it will be a pain to correct all argument names to lowercase. // HeavenMonkey 11:44, 6 June 2009 (UTC)
- I think we should use the same scheme as all other mainspace templates, which means lower case. - anja 11:47, 6 June 2009 (UTC)
- That makes sense, although alttext[1...15] will look strange. Maybe rename it to greytext[1...15] then? // HeavenMonkey 11:52, 6 June 2009 (UTC)
- For location templates, we use map1 and map1-text, that could work maybe? So we could use alt-text1 or something similar. - anja 11:54, 6 June 2009 (UTC)
- Ah ofcourse! I thought uc meant universal case or something. I wondered what was wrong with that. Id suggest doing any tests on lowercase. Anything should be case-independent imo. Cases just add to structure. Not sure about alttext or greytext though. Imo think alt is more logical. (greentext anyone? - thats another option ofc)-- Karasu (talk) 11:56, 6 June 2009 (UTC)
- That makes sense, although alttext[1...15] will look strange. Maybe rename it to greytext[1...15] then? // HeavenMonkey 11:52, 6 June 2009 (UTC)
- I think we should use the same scheme as all other mainspace templates, which means lower case. - anja 11:47, 6 June 2009 (UTC)
- I changed all the {{uc:}} to {{lc:}} since you added some lowercase words in the switch. Still case insensative, only now the lowercase words in the switch will match. But if we are going to kick all capitals from the template, the sooner the better. When the template is used widely it will be a pain to correct all argument names to lowercase. // HeavenMonkey 11:44, 6 June 2009 (UTC)
- I'll add that - it's a simple fix. -- Karasu (talk) 17:51, 5 June 2009 (UTC)
- I was mainly thinking of item name and item color, why not just name and color, of course it is about an item :) - anja 17:49, 5 June 2009 (UTC)
(Reset indent) alt-text1 sounds good to me. Casting to lowercase is only needed when comparing with other values anyway, so atm only with the colors. // HeavenMonkey 11:59, 6 June 2009 (UTC)
Did you guys notice[edit]
this topic and the ones above it are all part of the * indent thingy just under the Lists header? Should be fixed somehow. — Why 14:13, 16 June 2009 (UTC)
- Nevermind. Blame Google Chrome. It works fine in Firefox. — Why 14:14, 16 June 2009 (UTC)
<ul> <li> <table> </li> </ul> </table>
- Obviously wrong. I wouldn't recommend using this in a list but it's probably possible to fix this by commenting out all newline with <!-- -->. I'll go do that now. // HeavenMonkey 22:46, 16 June 2009 (UTC)
- Writing it in html is just bad form anyway. Should use wikicode. -- Wyn 22:49, 16 June 2009 (UTC)
- I have to disagree there since we actually need to modify the css of the table. This isn't a data
tabetable, it's a layout table. I know tables for layout is generally a bad thing, but it's the best way to have IE6 show something close to what it's supposed to be. Anyway, I escaped all relevant newlines and it's fixed.// HeavenMonkey 23:01, 16 June 2009 (UTC)- Well, I don't understand why you are worried about a browser that is 2 versions out of date. But it's your template, do as you see fit. I still disagree. -- Wyn 10:40, 17 June 2009 (UTC)
- It is in the main space, and it is used in several main space articles, so I guess it is "our" template, actually. I don't see how IE6 is a valid argument. Afaik, no other table on this wiki's main space is built especially for IE6, so I suggest, to keep it editable for the masses, as it is actually in the main space, to convert it to wikicode. Or to move/duplicate it to your userpage. I do like how it looks though, so I'd prefer a wikicoded version in mainspace. — Why 11:19, 17 June 2009 (UTC)
- Well, I don't understand why you are worried about a browser that is 2 versions out of date. But it's your template, do as you see fit. I still disagree. -- Wyn 10:40, 17 June 2009 (UTC)
- I have to disagree there since we actually need to modify the css of the table. This isn't a data
- Writing it in html is just bad form anyway. Should use wikicode. -- Wyn 22:49, 16 June 2009 (UTC)
- Obviously wrong. I wouldn't recommend using this in a list but it's probably possible to fix this by commenting out all newline with <!-- -->. I'll go do that now. // HeavenMonkey 22:46, 16 June 2009 (UTC)
(Reset indent) It can't be done with wikicode... At least not without adding a couple of definitions to the css file. Unless of course I'm wrong, in which case I happily invite you to change it all into wikicode. And the template isn't built especially for IE6. The table is just an easy solution which happens to be the one working best in older versions of IE. // HeavenMonkey 11:43, 17 June 2009 (UTC)
- Also note that using wikicode wouldn't help much anyway. In the end it still has to convert to html and using wikicode will make the end code much larger and requires more conversion. Currently it's not too difficult to edit and see what is going on. You could add comments if you like. Also - a LOT of people are still using IE6 (it's still standard in WinXP) and especially if it's used in mainspace we should concern ourselves how it works on common browsers. -- Karasu (talk) 18:31, 17 June 2009 (UTC)
Wikilinks[edit]
Could they somehow be included in the template, basic terms like Energy, et cetera? — Why 14:23, 16 June 2009 (UTC)
- Easily.. as soon as we know how to add style to [[wikilink]] or if we use another type of linking. -- Karasu (talk) 16:17, 16 June 2009 (UTC)
- Well, text processing is impossible, so the wikilink has to be included in the actual information passed to the template. It's possible to do that with a span like this: Energy. However, hiding the underline shown on mouseover is impossible. It's probably best to underline links always though, so it's clear it is a link, like so: Energy. But, it has to be done manually when passing the data to the template. // HeavenMonkey 22:39, 16 June 2009 (UTC)
- Why is this template written in html anyway. It makes it impossible for the avarage wiki user to edit it.
And we don't need to hide the mouseover underline, hiding the link defeats the point of having one inthe first place. Anyway,I strongly support rewriting this thing in wikicode. — Why 10:28, 17 June 2009 (UTC)- Nvm about the hiding links thingy, I misread your comment. — Why 10:31, 17 June 2009 (UTC)
- It's written in HTML because it simply can't be done in wikicode.// HeavenMonkey 11:45, 17 June 2009 (UTC)
- Nvm about the hiding links thingy, I misread your comment. — Why 10:31, 17 June 2009 (UTC)
- Why is this template written in html anyway. It makes it impossible for the avarage wiki user to edit it.
- Well, text processing is impossible, so the wikilink has to be included in the actual information passed to the template. It's possible to do that with a span like this: Energy. However, hiding the underline shown on mouseover is impossible. It's probably best to underline links always though, so it's clear it is a link, like so: Energy. But, it has to be done manually when passing the data to the template. // HeavenMonkey 22:39, 16 June 2009 (UTC)
Completely CSS borders[edit]
Instead of the current method using images, we could use complete CSS borders. webkit and mozilla have extensions that allow rounded corners using CSS alone, maybe some more browsers too. It would drastically cut back the amount of code. The downside is that it doesn't really look the same since GW doesn't use a simple line as border, but really an image. And in browsers such as IE it would look simply like a square.
Anyway, it would look like this:
As opposed to the current:
Sundering Hand Axe of Fortitude Slashing Dmg: 6-28 (Requires 9 Axe Mastery) Armor penetration +20% (Chance: 20%) Inscription: "Strength and Honor" Damage +15% (while Health is above 50%) Health +30
|
||
Hardly any difference, but a lot cleaner codewise. Big drawback of course that it only works in Mozilla, webkit and CSS3 browsers. // HeavenMonkey 21:56, 19 June 2009 (UTC)
- This appears so much better than the
ugly piece of trash that was actually implemented with the failing corners, i wonder why they didn't use this one?--File:User Chieftain Alex Chieftain Signature.pngChieftain Alex 14:13, 19 August 2011 (UTC)- The corners didn't use to fail like that. Fixed them in fact. Still, switching to CSS3 might be viable now. // HeavenMonkey 15:41, 19 August 2011 (UTC)
- Well done. much improved. <3 File:User Chieftain Alex Chieftain Signature.pngChieftain Alex 15:44, 19 August 2011 (UTC)
- The corners didn't use to fail like that. Fixed them in fact. Still, switching to CSS3 might be viable now. // HeavenMonkey 15:41, 19 August 2011 (UTC)
Added some stuff[edit]
I added some more stuff into the template as follows;
- Changed/Added in more Text so that that maximum number of things you can have is now 50, instead of 15 (for more variety and more awesome customisable items).
Hope you don't mind. -- §Lacky§ Talk 02:29, 20 June 2009 (UTC)
- 50 sure is a lot, but I find it hard to think of a reason to mind. So much repetition of the same code might be a reason to stuff it in a template though? Like Template:item info/line and Template:item info/color (for the color array). What do you guys think? // HeavenMonkey 10:39, 20 June 2009 (UTC)
- Why 50? As we've been before - 20 lines would've been enough for everything, maybe a few more. IMO it's too much. We could of course split up a few tasks, but we shouldn't put templates in templates. Any edit would require multiples purges before it would show up correctly. Each addition will also take much longer to show up. If there's a way of reducing the amount of code (scripts?) inside the template I'd support that. -- Karasu (talk) 11:07, 20 June 2009 (UTC)
- I think if you edit a template used in another template it all gets purged down. I've done it in some of my user space templates and it works fine. Changes show up immideatly. // HeavenMonkey 11:14, 20 June 2009 (UTC)
- And right now the same code is present 50 times, and one piece even 51 times. Changing the list of colours requires changing 51 identical pieces of code. With a template for the colour array it requires only one change. // HeavenMonkey 11:37, 20 June 2009 (UTC)
- Would you all PLEASE install the LoopFunctions WIKI extension. If I understand the description of it, it can handle up to 100 reps with MUCH less code. I asked for it ages ago and got shot down because "we don't need it" and "it would not be used". Well, it could be used here! --Max 2 14:04, 20 June 2009 (UTC)
- And right now the same code is present 50 times, and one piece even 51 times. Changing the list of colours requires changing 51 identical pieces of code. With a template for the colour array it requires only one change. // HeavenMonkey 11:37, 20 June 2009 (UTC)
- I think if you edit a template used in another template it all gets purged down. I've done it in some of my user space templates and it works fine. Changes show up immideatly. // HeavenMonkey 11:14, 20 June 2009 (UTC)
- Why 50? As we've been before - 20 lines would've been enough for everything, maybe a few more. IMO it's too much. We could of course split up a few tasks, but we shouldn't put templates in templates. Any edit would require multiples purges before it would show up correctly. Each addition will also take much longer to show up. If there's a way of reducing the amount of code (scripts?) inside the template I'd support that. -- Karasu (talk) 11:07, 20 June 2009 (UTC)
This code now seriously need some factoring...Elephant 16:22, 20 June 2009 (UTC)
- Hmm.. Ok - it doesn't show any problems. Sorry I really got the impression it would give problems. Also Lacky found a use for 45 lines ^^ on his userpage. If it doesn't give any problems I could agree with 50.. -- Karasu (talk) 21:18, 20 June 2009 (UTC)
- Now template code got factored, you can easily extend it for any amount of lines you want... Elephant 21:30, 20 June 2009 (UTC)
- That doesn't mean we should add another 20 lines just like that. If we want the code to be used a lot I'd like to reduce the amount that's being processed and ends up on your page. What would be most efficient is something like LoopFunctions that generates up to what is needed in a low-cost way.-- Karasu (talk) 21:37, 20 June 2009 (UTC)
- In the current state we can't do that. LoopFunctions would certainly add flexibility for sure, but wouldn't necessarly increase performances, since the parser would have to do additionnal processing, and rendered results are cached anyway. But having this wiki extensions or not is probably not for this Talk page.
- Factoring here was for readability and to reduce redundancies.Elephant 22:14, 20 June 2009 (UTC)
- Generally, hard coding is faster than looping. Of course, looping 1 if statement only 5 times could very well be faster than 50 if statements. I'm not sure how efficient the loop extension is though. The template system is pretty darn efficient, the code is a lot more readable and I haven't seen a noticeable a drop of speed. And I don't have to use a regex tool to make the same change to every line anymore :) // HeavenMonkey 22:26, 20 June 2009 (UTC)
- Hmm, I think if someone (like Lacky ^^) really wants a template with 45 lines he should copy it into his userspace and extend it. I have no clue to the processing time of 40 lines (might not be a lot) but it's not required for normal items. The longest real item around is probably Kerrsh's Staff and that's only 9 lines. So I agree, 20 should (easily) do. // HeavenMonkey 22:35, 20 June 2009 (UTC)
- The reason why I extended it to 50 was because I was using about 47 lines of code to make an ub3r weapon. =P AND YOU DELETED IT. It took me like an hour to change it up to 50. Oh well, I will just copy it into my userspace and then change it back up to 50...again...hehe. I too wish there was an easier way to make it have up to like 50 lines so that we could make our own customisable weapons sort of thing. But oh well. -- §Lacky§ Talk 02:55, 21 June 2009 (UTC)
- Hmm, I think if someone (like Lacky ^^) really wants a template with 45 lines he should copy it into his userspace and extend it. I have no clue to the processing time of 40 lines (might not be a lot) but it's not required for normal items. The longest real item around is probably Kerrsh's Staff and that's only 9 lines. So I agree, 20 should (easily) do. // HeavenMonkey 22:35, 20 June 2009 (UTC)
- Generally, hard coding is faster than looping. Of course, looping 1 if statement only 5 times could very well be faster than 50 if statements. I'm not sure how efficient the loop extension is though. The template system is pretty darn efficient, the code is a lot more readable and I haven't seen a noticeable a drop of speed. And I don't have to use a regex tool to make the same change to every line anymore :) // HeavenMonkey 22:26, 20 June 2009 (UTC)
- That doesn't mean we should add another 20 lines just like that. If we want the code to be used a lot I'd like to reduce the amount that's being processed and ends up on your page. What would be most efficient is something like LoopFunctions that generates up to what is needed in a low-cost way.-- Karasu (talk) 21:37, 20 June 2009 (UTC)
- Now template code got factored, you can easily extend it for any amount of lines you want... Elephant 21:30, 20 June 2009 (UTC)
What kind of item...[edit]
You should add in a thing saying what kind of item it is, whether it be a one-handed or two-handed staff, a off-hand item like a focus or shield or something etc. and have the template be like:
item_type = two-handed staff
and that would result in it saying it's a two-handed staff or something. -- §Lacky§ Talk 04:41, 21 June 2009 (UTC)
- There was something like that before, but this template can really replicate any item. There are a lot of different rules governing the different types of items, so putting them all in one template is a bit hard. But, building a staff template on top of this is easy. Since there are so many different sets of rules, different templates for different item types is best. // HeavenMonkey 11:16, 21 June 2009 (UTC)
- Alright, well, do you know any other such templates? Any that can replicate he "two-handed staff" text etc.? -- §Lacky§ Talk 01:47, 22 June 2009 (UTC)
- I don't think there is one at the moment, but I could make one, or someone else. What should it be called? Template:item info/staff maybe? // HeavenMonkey 11:14, 22 June 2009 (UTC)
- Or simply Template:staff info? Or perhabs Template:item staff info? Or Template:item staff? Yugh, so many possibilities. // HeavenMonkey 11:20, 22 June 2009 (UTC)
- I don't think there is one at the moment, but I could make one, or someone else. What should it be called? Template:item info/staff maybe? // HeavenMonkey 11:14, 22 June 2009 (UTC)
- Alright, well, do you know any other such templates? Any that can replicate he "two-handed staff" text etc.? -- §Lacky§ Talk 01:47, 22 June 2009 (UTC)
(Reset indent) Probably "Template:item info/staff" is not too bad. A simple list of some other kind of items : Item.
That said, is there any consensus of where it should or could get used ?
It is a replication of display of stats in ingame floating boxes, and probably don't fit the current GWW guides. Elephant 12:14, 22 June 2009 (UTC)
- I was thinking maybe something like Template:item_info/type...well, like...in the parameters, it could be like if item_type = 2HStaff then result = two-handed staff or something like that...if that makes any sense at all...I don't know...it's 12:47am here in Australia at the moment. I have no clue if half the stuff I am saying makes sense right now...lol -- §Lacky§ Talk 14:48, 22 June 2009 (UTC)
- Voila: Template:item info/staff. I used new parameter names because of what Anja said. We may want to use these parameter names for the main template too. Could ask poke to do a bot run to convert all the transclusions. // HeavenMonkey 12:10, 23 June 2009 (UTC)
- The only difficulty I had was to get "Two-handed" below all other text until I realised empty lines don't show up and I simply added it at line
2030. // HeavenMonkey 12:16, 23 June 2009 (UTC)- Eh...this is going to make it a bit difficult for me since, I use my own variation of this template. My own variation of this template is basically, I changed the functionality to being able to have 50 lines of text. How exactly am I going to implement/put this into my variation? -- §Lacky§ Talk 02:24, 24 June 2009 (UTC)
- EDIT: I like the look of Template:item info/staff. You should modify it into the Template:item info/wand, Template:item info/shield, Template:item info/focus, etc. as well. Would look and be pretty nifty I reckon, eh? -- §Lacky§ Talk 02:55, 24 June 2009 (UTC)
- EDIT2: I just remembered/saw, with my variation, I just put in a new line of code with the Text# = one-handed etc. then put it CustomColor# = N so it brings out the same result. -- §Lacky§ Talk 03:06, 24 June 2009 (UTC)
- EDIT: I like the look of Template:item info/staff. You should modify it into the Template:item info/wand, Template:item info/shield, Template:item info/focus, etc. as well. Would look and be pretty nifty I reckon, eh? -- §Lacky§ Talk 02:55, 24 June 2009 (UTC)
- Eh...this is going to make it a bit difficult for me since, I use my own variation of this template. My own variation of this template is basically, I changed the functionality to being able to have 50 lines of text. How exactly am I going to implement/put this into my variation? -- §Lacky§ Talk 02:24, 24 June 2009 (UTC)
- The only difficulty I had was to get "Two-handed" below all other text until I realised empty lines don't show up and I simply added it at line
- Voila: Template:item info/staff. I used new parameter names because of what Anja said. We may want to use these parameter names for the main template too. Could ask poke to do a bot run to convert all the transclusions. // HeavenMonkey 12:10, 23 June 2009 (UTC)
(Reset indent) You can simply copy the entire template and change every occurrence of {{item info}} to your personal template. If you want to support 46 lines (4 already taken) you'll have to add more too. See how far you get, if you need help just point me to the template. I'll make the other templates as well, but I'm away for (at least) two days. Someone else can do it too. I would suggest following the parameter name scheme I used in Template:item info/staff since that's indeed hoe it is outlined by Guild Wars Wiki:Formatting/Templates (just checked yesterday) // HeavenMonkey 08:48, 24 June 2009 (UTC)
- It's alright, the way I have it does the same effect as well. Although, I do notice, in you template, the two-handed grey part is a different shade than the other gray colours? -- §Lacky§ Talk 11:48, 24 June 2009 (UTC)
- I see, grey wasn't in the color list so it used the CSS grey. Gray was in the color list. Anyway, I added grey to the list too so that should be fixed (HeavenMonkey @ 85.147.33.102 11:50, 25 June 2009 (UTC)
- Yes, it is fixed now. Nice work! Now to just modify that to /wand, /shield, /focus etc. -- §Lacky§ Talk 02:28, 26 June 2009 (UTC)
- I updated the staff template to show unique staves correctly (with the HSR on the third line and green instead of on the first line and white). Also created Template:item info/shield. I'll add more item types later. For martial weapons it will need either a type parameter (sword, daggers, hammer) or a both-handed and a two-handed parameter. I'm leaning towards a type parameter myself and deduct the rest from that. // HeavenMonkey 16:23, 26 June 2009 (UTC)
- Thanks for that. It's brilliant. ^_^ -- §Lacky§ Talk 01:32, 28 June 2009 (UTC)
- I updated the staff template to show unique staves correctly (with the HSR on the third line and green instead of on the first line and white). Also created Template:item info/shield. I'll add more item types later. For martial weapons it will need either a type parameter (sword, daggers, hammer) or a both-handed and a two-handed parameter. I'm leaning towards a type parameter myself and deduct the rest from that. // HeavenMonkey 16:23, 26 June 2009 (UTC)
- Yes, it is fixed now. Nice work! Now to just modify that to /wand, /shield, /focus etc. -- §Lacky§ Talk 02:28, 26 June 2009 (UTC)
- I see, grey wasn't in the color list so it used the CSS grey. Gray was in the color list. Anyway, I added grey to the list too so that should be fixed (HeavenMonkey @ 85.147.33.102 11:50, 25 June 2009 (UTC)
(Reset indent) Al right, the hardest one so far: Template:item info/martial. Been rigged so it takes the correct defaults depending on the weapon type. // HeavenMonkey 12:51, 28 June 2009 (UTC)
- Wow, that's awesome. Your best one yet? How much code did you need? Sheesh. lol -- §Lacky§ Talk 02:32, 29 June 2009 (UTC)
- 5 sub-templates lol, but it's not really hard, it's just putting all the pieces together // HeavenMonkey 11:54, 29 June 2009 (UTC)
- Template:item info/martial, Template:item info/shield, Template:item info/staff, Template:item info/wand, Template:item info/focus. Did I miss any? // HeavenMonkey 12:55, 29 June 2009 (UTC)
- Well, according to Item;
- Template:item info/martial, Template:item info/shield, Template:item info/staff, Template:item info/wand, Template:item info/focus. Did I miss any? // HeavenMonkey 12:55, 29 June 2009 (UTC)
- 5 sub-templates lol, but it's not really hard, it's just putting all the pieces together // HeavenMonkey 11:54, 29 June 2009 (UTC)
- Weapon
* Martial weapon o Melee weapon + Axe + Dagger + Hammer + Scythe + Sword o Ranged weapon + Bow + Spear * Spellcasting weapon o Staff o Wand * Offhand item o Focus item o Shield
Since the template is Item_info, shouldn't we do this for all items? Or should we rename to weapon/off-hand info or something? -- §Lacky§ Talk 15:02, 29 June 2009 (UTC)
- Well, item_info can be used for all items, the sub-templates only for weapons. It is possible to build more templates for specific item types such as runes, insignias, inscriptions, weapon upgrades etc, but do we really need those? Weapons have much more variables, whereas runes, insignias etc would only have a small static part and the rest filled in by the custom lines. // HeavenMonkey 23:49, 29 June 2009 (UTC)
- We don't have to do it, I am just saying, we could. It would be good to see this for all items. -- §Lacky§ Talk 02:22, 30 June 2009 (UTC)
- So make one for any item you want to see it for. Drogo Boffin 02:28, 30 June 2009 (UTC)
- We plan on hopefully doing that for items...also, I don't know if it is just me, and I don't mean any offence, but from some of the posts I have seen you make, you tend to not really help or anything, you tend to just jump into conversations and demand stuff and also butt-in to stuff you aren't even really apart of, if at all. -- Lacky 06:04, 14 July 2009 (UTC)
- So make one for any item you want to see it for. Drogo Boffin 02:28, 30 June 2009 (UTC)
- We don't have to do it, I am just saying, we could. It would be good to see this for all items. -- §Lacky§ Talk 02:22, 30 June 2009 (UTC)
There should be similiar template[edit]
but for skills, but I'm not experienced enough with wikicode. --83.29.96.178 17:09, 13 July 2009 (UTC)
- Do you mean like, showing what the skill does as it does in-game? -- Lacky 06:00, 14 July 2009 (UTC)
- yeah --83.28.193.23 11:13, 15 July 2009 (UTC)
Doesn't work with Tables.[edit]
I'm not sure what edit caused it, I havn't been around for awhile, but if you look here, User:StimpsonJKat/Minipets, You'll see that when used with a table, the background gets wierd.
Just thought I'd mention it. - Stimpson J Kat 20:35, 25 August 2011 (UTC)
- It's a CSS rule from the wikitable class. I've overridden the problematic style rules, but the wikitable class should use child selectors and not descendant selectors, because this way it effects all tables inside the one with the wikitable class, even if those tables don't specify the wikitable class. Bad practise, although stacking tables is bad practise too. // HeavenMonkey 20:56, 25 August 2011 (UTC)
Main space[edit]
I think it is important to remove this template from main space articles. There is no good precedent for using it in main space to begin with, and although it does reflect in-game content accurately in terms of looks, it detracts from the wiki aesthetically. - Infinite - talk 15:29, 8 August 2017 (UTC)
- As a for instance, you'd prefer having a text descriptor instead of the template on pages like Ascalon Razor? Further examples can be found here. G R E E N E R 17:15, 8 August 2017 (UTC)
- I think it would look more wiki-esque to have plain text, personally. The dark background of the template is very bold and in the face. This sooner makes me think of user space. If other users instead prefer to use this template, it might be a good idea to use it more prominently. - Infinite - talk 19:53, 8 August 2017 (UTC)